Azure / terraform-azurerm-avm-ptn-virtualwan

MIT License
5 stars 12 forks source link

[AVM Module Issue]: vHub Resource Group not being used #42

Closed krottiers closed 2 months ago

krottiers commented 4 months ago

Check for previous/existing GitHub issues

Module specific issue

Issue Type?

Bug

(Optional) Module Version

No response

(Optional) Correlation Id

No response

Description

When providing a resource group in the vhub configuration this isn't used. Instead the default Azure vWAN resource group

Resource deployment references to local.resource_group_name instead of the passed value:

resource "azurerm_virtual_hub" "virtual_hub" {
  for_each = local.virtual_hubs != null && length(local.virtual_hubs) > 0 ? local.virtual_hubs : {}

  location            = each.value.location
  name                = each.value.name
  resource_group_name = local.resource_group_name
  address_prefix      = each.value.address_prefix
  tags                = try(each.value.tags, {})
  virtual_wan_id      = azurerm_virtual_wan.virtual_wan.id
}

locals:

virtual_hubs = {
    for key, vhub in var.virtual_hubs : key => {
      name           = vhub.name
      location       = vhub.location
      resource_group = try(vhub.resource_group, "")
      address_prefix = vhub.address_prefix
      tags           = try(vhub.tags, {})
    }
  }
khushal08 commented 2 months ago

Fix pushed in v0.4.2.0