Azure / terraform-azurerm-avm-ptn-virtualwan

MIT License

5 stars 12 forks source link

Port fixes from https://github.com/krottiers/terraform-azurerm-avm-pt… #46

Closed jaredfholgate closed 3 months ago

jaredfholgate commented 3 months ago

Description

Bugfix for #44

Type of Change

[ ] Non-module change (e.g. CI/CD, documentation, etc.)
[ ] Azure Verified Module updates:
- [x] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in locals.version.tf.json:
- [x] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in locals.version.tf.json.
- [ ] Breaking changes and I have bumped the MAJOR version in locals.version.tf.json.
- [ ] Update to documentation

Checklist

[x] I'm sure there are no other open Pull Requests for the same update/change
[x] My corresponding pipelines / checks run clean and green without any errors or warnings
[x] I did run all pre-commit checks

ChrisSidebotham commented 3 months ago

@khushal08 - The proposed change is not currently tested in the deployment validation of the testExamples due to the requirements of an existing er_circuit I believe.