Azure / terraform-azurerm-avm-ptn-virtualwan

The Azure Verified Module for the Virtual WAN Pattern

https://registry.terraform.io/modules/Azure/avm-ptn-virtualwan/azurerm/latest

MIT License

11 stars 17 forks source link

Telemetry, output, and bug fixes #90

Closed jchancellor-ms closed 3 months ago

jchancellor-ms commented 4 months ago

Description

This PR includes a number of small changes intended to correct reported issues and implement the latest telemetry updates.

Fixes #74 Fixes #88 Closes #74 Closes #88

Type of Change

[x] Non-module change (e.g. CI/CD, documentation, etc.)
[x] Azure Verified Module updates:
- [x] Bugfix containing backwards compatible bug fixes
- [x] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an issue to report it yet.
- [x] Feature update backwards compatible feature updates.
- [ ] Breaking changes.
- [x] Update to documentation

Checklist

[x] I'm sure there are no other open Pull Requests for the same update/change
[x] My corresponding pipelines / checks run clean and green without any errors or warnings
[x] I did run all pre-commit checks

jchancellor-ms commented 4 months ago

@khushal08 or @jaredfholgate - Can you please approve the e2e tests and review this PR? It addresses some of the longer running issues and adds the new telemetry (modtm) provider updates. The TFlint tests are failing due to the new WAF rule for VNet VPN gateways to be active/active on one of the examples. I can try setting it to active/active if you concur.