Azure / terraform-azurerm-avm-ptn-vnetgateway

AVM Terraform Pattern Module for Virtual Network Gateway
https://registry.terraform.io/modules/Azure/avm-ptn-vnetgateway/azurerm/latest
MIT License
9 stars 8 forks source link

Allow any 4.x version #89

Closed spowser closed 1 week ago

spowser commented 2 weeks ago

Description

Allow versions between 4.0.0 and 5.0.0

Fixes #88 Closes #88 -->

Type of Change

Checklist

luke-taylor commented 2 weeks ago

Nice work, I think ~> 4.0 would work better (taking the latest v4 minor GEQ 0), since 3.116.0 won't be compatible with the current code.

spowser commented 2 weeks ago

Ack. Yes, the floor should be 4.0.0. Thanks for catching that!

luke-taylor commented 1 week ago

@spowser Hey, another security PR has been merged and it's now causing merge conflicts here, can you quickly do a rebase to resolve these merge conflicts?

Also, it may be worth removing the < 5.0.0 part since it's redundant if we're using ~> 4.0 since this necessarily means < 5.0.0

spowser commented 1 week ago

@luke-taylor Done and removed the 5.0.0.