search

Azure / terraform-azurerm-avm-res-app-managedenvironment

AVM Terraform module for Container Apps Managed Environments
MIT License
5 stars 5 forks source link

AVM alignment tasks for app managed environment #11

Closed kewalaka closed 7 months ago

kewalaka commented 8 months ago

This addresses the 'module inputs' comment in https://github.com/Azure/terraform-azurerm-avm-res-app-managedenvironment/issues/9, and fixes a number of issues raised by governance tooling (grept)

I've left the e2e workflow running in github for now until the internal runners are available.

segraef commented 7 months ago

Still working on fixing the liniting?

kewalaka commented 7 months ago

@segraef apologies have been away, just added the missing diagnostics block, copying it from the Keyvault implementation.

./avm pr-check looks good locally to me, nothing else change substantially

segraef commented 7 months ago

@segraef apologies have been away, just added the missing diagnostics block, copying it from the Keyvault implementation.

./avm pr-check looks good locally to me, nothing else change substantially

Thanks, looks good to me. Triggering @Azure/avm-core-team-technical to review.