Azure / terraform-azurerm-avm-res-app-managedenvironment

AVM Terraform module for Container Apps Managed Environments

MIT License

5 stars 5 forks source link

fix: add prevent deletion block to provider block in examples #34

Closed kewalaka closed 6 months ago

kewalaka commented 6 months ago

Description

Type of Change

[ ] Non-module change (e.g. CI/CD, documentation, etc.)
[ ] Azure Verified Module updates:
- [x] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in locals.version.tf.json:
- [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in locals.version.tf.json.
- [ ] Breaking changes and I have bumped the MAJOR version in locals.version.tf.json.
- [ ] Update to documentation

Checklist

[x] I'm sure there are no other open Pull Requests for the same update/change
[x] My corresponding pipelines / checks run clean and green without any errors or warnings
[x] I did run all pre-commit checks

kewalaka commented 6 months ago

@segraef done - i haven't re-run any E2E tests because it just looks like code re-arrangement

pre-commit seems to now run avmfix

pr-check was already all good

segraef commented 6 months ago

@kewalaka feel free to merge.