[AVM Module Issue]: adding LAW requires a shared key, which is not required when using the resource directly - Githubissues

Azure / terraform-azurerm-avm-res-app-managedenvironment

AVM Terraform module for Container Apps Managed Environments

MIT License

5 stars 4 forks source link

[AVM Module Issue]: adding LAW requires a shared key, which is not required when using the resource directly #39

Open kewalaka opened 5 months ago

kewalaka commented 5 months ago

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Module specific issue

[X] I confirm that this issue is about this AVM module and not about the resource itself, or how to use Terraform.

Issue Type?

Feature Request

(Optional) Module Version

0.1.2

(Optional) Correlation Id

No response

Description

When specifying log analytics, it is necessary to specify both the customer ID and customer key.

This is because we are using AzAPI under the hood, and that appears to be the requirement there

https://learn.microsoft.com/en-us/azure/templates/microsoft.app/managedenvironments?pivots=deployment-language-terraform#loganalyticsconfiguration-2

It is not clear from the docs if the key is optional

By comparison, when using AzureRM, only the workspace ID is required:

https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/container_app_environment#log_analytics_workspace_id

This is preferable, as it avoids have to fetch & pass the LAW key.

kewalaka commented 4 months ago

have a fix in testing (linked above) that i'm hoping will address this.