Azure / terraform-azurerm-avm-res-app-managedenvironment

AVM Terraform module for Container Apps Managed Environments
MIT License
7 stars 6 forks source link

Fix workload profile setting #83

Closed alefteris closed 1 month ago

alefteris commented 1 month ago

Description

Setting a workload profile wasn't working, because the check for consumption profile to set workload_profiles_consumption_enabled didn't account for the fact that the workload_profile variable includes also the max/min count with default values. So I fixed this part. Also fixed is the part that sets the workloadProfiles for the azapi resource to use the correct format.

The rest of the changes are white-space changes from running the avm pre-commit and adding the modtm provider that was needed for the module to work, because of previous commits in main the branch.

avm pr-check fails because some more changes are needed, I think because of updates to interface specs.

Type of Change

Checklist

microsoft-github-policy-service[bot] commented 1 month ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!TIP] For additional guidance on how to triage this issue/PR, see the TF Issue Triage documentation.

kewalaka commented 1 month ago

@alefteris this looks good but i'm going to close in favour of the azure/wp-fix branch where i've added linting fixes