Azure / terraform-azurerm-avm-res-app-managedenvironment

AVM Terraform module for Container Apps Managed Environments

MIT License

7 stars 6 forks source link

feat: specify log analytics via resource key rather than using shared keys #88

Open kewalaka opened 1 month ago

kewalaka commented 1 month ago

Description

This changes the mechanism to specify the log analytics workspace to use the LAW resource id rather than specifying the shared key.

Note this also includes lint fixes which are in the wp-fix branch, be best if that is folded first and this rebased. https://github.com/Azure/terraform-azurerm-avm-res-app-managedenvironment/pull/87

Closes #39 -->

Type of Change

[ ] Non-module change (e.g. CI/CD, documentation, etc.)
[ ] Azure Verified Module updates:
- [ ] Bugfix containing backwards compatible bug fixes
- [X] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an issue to report it yet.
- [ ] Feature update backwards compatible feature updates.
- [X] Breaking changes.
- [X] Update to documentation

Checklist

[X] I'm sure there are no other open Pull Requests for the same update/change
[X] My corresponding pipelines / checks run clean and green without any errors or warnings
[X] I did run all pre-commit checks

microsoft-github-policy-service[bot] commented 1 month ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!TIP] For additional guidance on how to triage this issue/PR, see the TF Issue Triage documentation.