Azure / terraform-azurerm-avm-res-authorization-roleassignment

AVM Terraform module for role assignments
https://registry.terraform.io/modules/Azure/avm-res-authorization-roleassignment
MIT License
9 stars 4 forks source link

[AVM Module Issue]: Add Principal Type to Role assignment #61

Closed mennaammar closed 2 months ago

mennaammar commented 3 months ago

Check for previous/existing GitHub issues

Issue Type?

Feature Request

(Optional) Module Version

v0.0.1

(Optional) Correlation Id

No response

Description

We have a policy in Azure that only groups and service principals can be used in role assignment. When we used this module, we got error 403 error as the principal type is not supplied as part of the terraform code.

Appreciate adding principal_type to

resource "azurerm_role_assignment" "this" { for_each = local.role_assignments

principal_id = each.value.principal_id scope = each.value.scope principal_type = each.value.type ----> needs to be added role_definition_id = each.value.role_definition_id }

microsoft-github-policy-service[bot] commented 3 months ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!NOTE] This label was added as per ITA06.

microsoft-github-policy-service[bot] commented 3 months ago

[!NOTE] The "Type: Feature Request :heavy_plus_sign:" label was added as per ITA20.

jaredfholgate commented 2 months ago

Released in v0.1.0