Azure / terraform-azurerm-avm-res-authorization-roleassignment

AVM Terraform module for role assignments
https://registry.terraform.io/modules/Azure/avm-res-authorization-roleassignment
MIT License
9 stars 3 forks source link

[AVM Module Issue]: Support v4 of azurerm #77

Open antoineozenne opened 17 hours ago

antoineozenne commented 17 hours ago

Check for previous/existing GitHub issues

Issue Type?

Bug

(Optional) Module Version

0.1.0

(Optional) Correlation Id

No response

Description

The versions of the providers are fixed (see in required_providers) so we can't use this module with others because we can't use a newer version of a provider. According to the Terraform doc:

If you are writing a shared Terraform module, constrain only the minimum required provider version using a >= constraint. This should specify the minimum version containing the features your module relies on, and thus allow a user of your module to potentially select a newer provider version if other features are needed by other parts of their overall configuration.

Can you please change the constraint for each provider?

jaredfholgate commented 13 hours ago

Hi @antoineozenne

It is not as simple as the HashiCorp docs make out. How do you handle breaking changes between major versions of provider?

You can see we have our own standards around this here: https://azure.github.io/Azure-Verified-Modules/specs/terraform/#id-tfnfr26---category-code-style---providers-in-required_providers

You can also see our plans for azurerm v4 support here: https://github.com/Azure/Azure-Verified-Modules/discussions/1338

In the case of this particular module, our intention is to convert it to use azapi instead of azurerm prior to it going to version 1. That will allow us to utilise it better moving forward and have less issues like this.

I don't have a timescale for this yet, but we can look to see if it will work with v4 of azurerm in the short term.