search

Azure / terraform-azurerm-avm-res-cdn-profile

AVM Terraform Module for Azure CDN Profiles
MIT License
3 stars 3 forks source link

[AVM Module Issue]: missing documentation for custom_domain_keys parameter of front_door_routes #38

Closed MikeDembek closed 3 months ago

MikeDembek commented 3 months ago

Check for previous/existing GitHub issues

Issue Type?

I'm not sure

(Optional) Module Version

0.1.0

(Optional) Correlation Id

No response

Description

Hello, the custom_domain_keys attribute is shown in the type block for front_door_routes but it is not otherwise documented or described. It would be helpful to update the documentation to reflect that the custom_domain_keys attribute links a custom domain with an endpoint.

didayal-msft commented 3 months ago

Thanks for the feedback! @MikeDembek . We will add this in the documentation and review other gaps and plug those as well.

For now, if it helps, usage of the attribute is available in the "afd_custom_domain_with_customer_managed_secret" example.

image

@Poven795909

Poven795909 commented 3 months ago

The documentation has been updated. Closing the issue.

MikeDembek commented 2 months ago

Hi, I'm still not seeing this in the current docs here:

https://registry.terraform.io/modules/Azure/avm-res-cdn-profile/azurerm/latest

Am I missing something?

Thanks for your work on this module!

didayal-msft commented 2 months ago

@MikeDembek Its updated now :) please check again.

MikeDembek commented 2 months ago

Confirmed! Thanks for getting that updated.