Azure / terraform-azurerm-avm-res-cognitiveservices-account

This Terraform module is designed to manage Azure Cognitive Services. It provides a comprehensive set of variables and resources to configure and deploy Cognitive Services in Azure.
https://github.com/Azure/terraform-azurerm-avm-res-cognitiveservices-account
MIT License
4 stars 5 forks source link

[AVM Module Issue]: The location property in the private endpoint object is ignored #18

Closed thenewnano closed 1 month ago

thenewnano commented 4 months ago

Check for previous/existing GitHub issues

Issue Type?

Bug

(Optional) Module Version

0.1.1

(Optional) Correlation Id

No response

Description

There are cases where we deploy an cognitive resource to a location other than the one of the vnet and private endpoints. the code for the private endpoint submodule should look like : location = coalesce(each.value.location, azurerm_cognitive_account.this.location) instead of : location = azurerm_cognitive_account.this.location

matt-FFFFFF commented 1 month ago

@lonegunmanb are you able to help here?

lonegunmanb commented 1 month ago

Hi @thenewnano I've checked the code:

location                      = each.value.location != null ? each.value.location : var.location

RR

We have a new updated private endpoint interface spec, now the private endpoint supports customized location, would you please recheck and confirm that? Thanks!

microsoft-github-policy-service[bot] commented 1 month ago
microsoft-github-policy-service[bot] commented 1 month ago

[!IMPORTANT] @thenewnano, this issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

[!TIP] To prevent further actions to take effect, one of the following conditions must be met:

  • The author must respond in a comment within 3 days of this comment.
  • The "Status: No Recent Activity :zzz:" label must be removed.
  • If applicable, the "Status: Long Term :hourglass_flowing_sand:" or the "Needs: Module Owner :mega:" label must be added.
microsoft-github-policy-service[bot] commented 1 month ago

[!WARNING] @thenewnano, this issue will now be closed, as it has been marked as requiring author feedback but has not had any activity for 7 days.

[!TIP] In case this issue needs to be reopened (e.g., the author responds after the issue was closed), the "Status: No Recent Activity :zzz:" label must be removed.