Azure / terraform-azurerm-avm-res-cognitiveservices-account

This Terraform module is designed to manage Azure Cognitive Services. It provides a comprehensive set of variables and resources to configure and deploy Cognitive Services in Azure.

https://github.com/Azure/terraform-azurerm-avm-res-cognitiveservices-account

MIT License

4 stars 5 forks source link

Use passed value for private endpoint location if set #19

Closed thenewnano closed 2 months ago

thenewnano commented 4 months ago

This changes the behavior to expected, as the location values send in as part of the private endpoint object shall be respected. Fixes #18

Description

Type of Change

[ ] Non-module change (e.g. CI/CD, documentation, etc.)
[ ] Azure Verified Module updates:
- [ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in locals.version.tf.json:
- [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in locals.version.tf.json.
- [ ] Breaking changes and I have bumped the MAJOR version in locals.version.tf.json.
- [ ] Update to documentation

Checklist

[x] I'm sure there are no other open Pull Requests for the same update/change
[ ] My corresponding pipelines / checks run clean and green without any errors or warnings
[x] I did run all pre-commit checks

lonegunmanb commented 2 months ago

Thanks @thenewnano for opening this pr to us! I'm closing this one since it has been implemented now. I'll release a new version ASAP. Thanks for your contribution!