search

Azure / terraform-azurerm-avm-res-compute-virtualmachinescaleset

MIT License
1 stars 7 forks source link

[VMSS Terraform AVM Review PG Feedback] #2 Best Practices #59

Open Kanik09 opened 1 month ago

Kanik09 commented 1 month ago

Please follow the below best practices for the corresponding modules. Not all practices should be followed for both default and max.

 

VMSS Best Practice Applicable AVM Module Applicable for Default Applicable for Max
Deploy VMSS with Flex Orchestration mode Terraform, Bicep Yes Yes
Configure VMSS autoscale to custom and configure scaling metrics Terraform, Bicep No Yes
Configure Predictive autoscale and atleast for forecast only Terraform, Bicep No Yes
Deploy VMSS across availaibility zones with VMSS flex Terraform, Bicep Yes Yes
Disable Force strictly even balance across zones to avoid scale in and out fail attempts Terraform, Bicep Yes Yes
Enable VMSS application health monitoring Terraform, Bicep Yes if condition shared over Email is met.  Yes if condition shared over Email is met. 
Enable Automatic Repair Policy Terraform, Bicep Requires health monitoring to be enabled. Requires health monitoring to be enabled. 
Set Patch orchestration options to Azure-orchestrated Terraform, Bicep Yes Yes
Upgrade VMSS Image versions scheduled to be deprecated or already retired Terraform, Bicep    
Configure Allocation Policy Spreading Algorithm to max spreading Terraform, Bicep Yes Yes
microsoft-github-policy-service[bot] commented 1 month ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!NOTE] This label was added as per ITA06.

microsoft-github-policy-service[bot] commented 3 weeks ago

[!WARNING] Tagging the AVM Core Team (@Azure/avm-core-team-technical-terraform) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

[!TIP]

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage :mag:" label must be removed as part of the triage process (when the issue is first responded to)!

[!NOTE] This message was posted as per ITA01TF.

microsoft-github-policy-service[bot] commented 1 week ago

[!WARNING] Tagging the AVM Core Team (@Azure/avm-core-team-technical-terraform) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

[!TIP]

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage :mag:" label must be removed as part of the triage process (when the issue is first responded to)!

[!NOTE] This message was posted as per ITA01TF.

microsoft-github-policy-service[bot] commented 1 week ago

[!CAUTION] This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-terraform) immediate attention as it hasn't been responded to within 6 business days.

[!TIP]

  • To avoid this rule being (re)triggered, the "Needs: Triage :mag:" and "Status: Response Overdue :triangular_flag_on_post:" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention :bangbang:" label once the issue has been responded to.

[!NOTE] This message was posted as per ITA02TF.