search

Azure / terraform-azurerm-avm-res-compute-virtualmachinescaleset

MIT License
4 stars 10 forks source link

[AVM Module Issue]: Azure DevOps build agent tag ignore #86

Open MikeDembek opened 1 month ago

MikeDembek commented 1 month ago

Check for previous/existing GitHub issues

Issue Type?

Feature Request

(Optional) Module Version

0.3.0

(Optional) Correlation Id

No response

Description

Hey, I'm using this module to deploy a VMSS to be used for Azure DevOps Build Agents. Configuring the VMSS as an agent pool in DevOps appears to apply these two hidden tags:

"__AzureDevOpsElasticPool": "example-pool-name",
"__AzureDevOpsElasticPoolTimeStamp": "10/2/2024 11:02:21 PM"

In turn, that results in a persistent change in TF like so:

2024-10-02T23:04:06.6891484Z       ~ tags                          = {
2024-10-02T23:04:06.6891853Z           - "__AzureDevOpsElasticPool"          = "example-pool-name" -> null
2024-10-02T23:04:06.6892315Z           - "__AzureDevOpsElasticPoolTimeStamp" = "10/2/2024 11:02:21 PM" -> null

I haven't observed any negative impact to the VMSS or agent pool and the tags get re-applied more-or-less immediately after being removed.

I realize there may not be a great way to deal with this as ignores have to be configured at the module level; if these tags are well-known maybe that would make sense to do here.

We could also fork the module and configure the ignores, but we're trying to avoid that extra overhead if we can.

We'd be open to other solutions or suggestions too. Thanks for taking a look.

microsoft-github-policy-service[bot] commented 3 weeks ago

[!WARNING] Tagging the AVM Core Team (@Azure/avm-core-team-technical-terraform) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

[!TIP]

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage :mag:" label must be removed as part of the triage process (when the issue is first responded to)!
terrymandin commented 3 weeks ago

Thanks @MikeDembek I will take a look.

microsoft-github-policy-service[bot] commented 19 hours ago

[!CAUTION] This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-terraform) immediate attention as it hasn't been responded to within 6 business days.

[!TIP]

  • To avoid this rule being (re)triggered, the "Needs: Triage :mag:" and "Status: Response Overdue :triangular_flag_on_post:" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention :bangbang:" label once the issue has been responded to.