search

Azure / terraform-azurerm-avm-res-databricks-workspace

MIT License
6 stars 5 forks source link

Initial commit #1

Closed acauret closed 5 months ago

acauret commented 5 months ago

Initial commit as discussed

acauret commented 5 months ago

@microsoft-github-policy-service agree

segraef commented 5 months ago

Thanks, can you show us successful e2e test runs in your fork? FYI, the e2e tests triggered by this PR will fail and shouldn't bother you, we're currently transitioning to self-hosted GitHub runners to fix this issue.

acauret commented 5 months ago

image

acauret commented 5 months ago

image

The SPN will need to be added to the Directory Readers role as the customer manged key example uses 'azuread_service_principal'

segraef commented 5 months ago

image

The SPN will need to be added to the Directory Readers role as the customer manged key example uses 'azuread_service_principal'

picture doesn't show up for me

segraef commented 5 months ago

Also added you as collaborator so you can start using a local branch. We need to move this PR to a local branch in order to get the e2e tests green for now until we moved to self-hosted runners.

segraef commented 5 months ago

Just updated main with latest changes from the template.

segraef commented 5 months ago

Hi @acauret did you find a chance to accept your invitation?

image

Please also make sure to resolve your conflicts, maybe you wait until #4 is merged which brings some more changes done via grept.

segraef commented 5 months ago

Set up a session to sync with @acauret tonight.