Added output databricks_access_connector_principal_ids

[marcelobern]

Description

Added output databricks_access_connector_principal_ids, so the access connector principal_id can be used in outside the module (e.g. azurerm_role_assignment). terraform-docs was used to updat README.md.

Type of Change

• [ ] Non-module change (e.g. CI/CD, documentation, etc.)
• [ ] Azure Verified Module updates:
  • [X] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in locals.version.tf.json:
  • [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
  • [ ] The bug was found by the module author, and no one has opened an issue to report it yet.
  • [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in locals.version.tf.json.
  • [ ] Breaking changes and I have bumped the MAJOR version in locals.version.tf.json.
  • [ ] Update to documentation

Checklist

• [X] I'm sure there are no other open Pull Requests for the same update/change
• [X] My corresponding pipelines / checks run clean and green without any errors or warnings
• [X] I did run all pre-commit checks

[marcelobern]

@microsoft-github-policy-service agree

[segraef]

Thanks @marcelobern, do you mind having a look at the linter errors, should be easy to fix and then I'm happy to approve.

[marcelobern]

@segraef sorry for the delayed response to this.

It should be good now.

[Dipak-Mistry-WTW]

Hi @segraef @jaredfholgate @prjelesi Is this just waiting for approval?

[prjelesi]

@segraef feel free to merge

[Dipak-Mistry-WTW]

This is good to have in the long term but I don't need it anymore as I have switched to User assigned managed identities instead which are output from another module.

[Dipak-Mistry-WTW]

Hi - Its seems we've changed direction and we do need this now!! Sorry for messing you about. I think the work is pretty much done. Is it just some quick linting fixes? @segraef @marcelobern

[segraef]

Approved e2e test run, let's see. @marcelobern please make sure to run ./avm pre-commit to get the linting green and bump up https://github.com/Azure/terraform-azurerm-avm-res-databricks-workspace/blob/main/locals.version.tf.json up to 0.2.0, thanks.

[marcelobern]

Bumped version.

Having issue with ./avm pre-commit (see error messages below). Any suggestions?

latest: Pulling from azterraform
Digest: sha256:8db46870078308c6d8310538903d0c8ee2d532a5ca99d6f8dfb0637fe6d51677
Status: Image is up to date for mcr.microsoft.com/azterraform:latest
curl: (6) Could not resolve host: raw.githubusercontent.com
make: *** No rule to make target 'pre-commit'.  Stop.

[Dipak-Mistry-WTW]

@jaredfholgate @segraef @marcelobern Has this fallen off the radar?

[segraef]

I'm about to fix the linter issues https://github.com/Azure/terraform-azurerm-avm-res-databricks-workspace/pull/51 which might require a rebase afterwards.

[segraef]

Predecessor: #53

[segraef]

Merged #53, please rebase #29 to get linters green, thank you for your patience and collaboration @marcelobern and @Dipak-Mistry-WTW.

[marcelobern]

@segraef , I did merge #53 but I am still having issues trying to run ./avm pre-commit locally:

latest: Pulling from azterraform
Digest: sha256:f19e62cacd83ab058742377bc4a561f9732845d9c4e07220dc89cceac5e69262
Status: Image is up to date for mcr.microsoft.com/azterraform:latest
curl: (6) Could not resolve host: raw.githubusercontent.com
make: *** No rule to make target 'pre-commit'.  Stop.

We will see it the check happen to work in the PR.

[marcelobern]

@segraef never mind, seems like I ran out of disk space due to the size of the images pulled by './avm pre-commit'.

I ran it successfully after cleaning up the disk and it removed the extra blank lines in the README, so I hope this will be all green now.