Azure / terraform-azurerm-avm-res-desktopvirtualization-hostpool

AVM for Desktop Virtualization Hostpools
https://registry.terraform.io/modules/Azure/avm-res-desktopvirtualization-hostpool/azurerm/latest
MIT License
3 stars 3 forks source link

[AVM Question/Feedback]: Hard-coded expiry time of host pool registration token #46

Closed lineardraft closed 2 months ago

lineardraft commented 2 months ago

Check for previous/existing GitHub issues

Description

Hello, Just wanted to check why is the expiration_date for azurerm_virtual_desktop_host_pool_registration_info hardcoded to 48h? As far as I know the maximum lifetime of the registration token is ~ 30 days. The question is, any specific reason why the value is not user customizable? Thanks a lot.

LINK: https://github.com/Azure/terraform-azurerm-avm-res-desktopvirtualization-hostpool/blob/2e66e67845b1698531aeef683ed7dc2e60f0a1c5/main.tf#L52C3-L52C48

microsoft-github-policy-service[bot] commented 2 months ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!NOTE] This label was added as per ITA06.

jensheerin commented 2 months ago

@lineardraft Thank you for the question! There is no specific reason, you are correct "The expiration period must be a valid duration less than or equal to 30 days."