Azure / terraform-azurerm-avm-res-insights-component

AVM Terraform Module for Application Insights
MIT License
2 stars 4 forks source link

[AVM Module Issue]: Resource naming condition incorrect #40

Closed captainhook closed 2 weeks ago

captainhook commented 1 month ago

Check for previous/existing GitHub issues

Issue Type?

Bug

(Optional) Module Version

0.1.2

(Optional) Correlation Id

No response

Description

Check for previous/existing GitHub issues

Issue Type?

Bug

(Optional) Module Version

0.1.2

(Optional) Correlation Id

No response

Description

The condition for Application Insights name is incorrect - https://github.com/Azure/terraform-azurerm-avm-res-insights-component/blob/f740c7e1c43001936ddff54f97a840ae4d477364/variables.tf#L12

The correct condition as per Microsoft documentation is: "1-260 chars, Can't use: %&\?/ or control characters. Can't end with space or period." source: https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/resource-name-rules#microsoftinsights

However on the Azure portal is says, "The resource name must contain between 1 to 255 characters inclusive. The name only allows alphanumeric characters, periods, underscores, hyphens and parenthesis and cannot end in a period."

microsoft-github-policy-service[bot] commented 1 month ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!TIP] For additional guidance on how to triage this issue/PR, see the TF Issue Triage documentation.

JFolberth commented 2 weeks ago

Closing as we resolved by #48