Azure / terraform-azurerm-avm-res-keyvault-vault

Azure Verified Module for Key Vault
https://registry.terraform.io/modules/Azure/avm-res-keyvault-vault/azurerm/latest
MIT License
23 stars 26 forks source link

feat: add key and secret ID values to output #121

Closed jchancellor-ms closed 4 months ago

jchancellor-ms commented 4 months ago

Description

Added the key and secret id and versionless_id values to the output. This is required for some AzureRM resources that use these ID's instead of the full resource_id as inputs.

Fixes #120 and closes #120

Type of Change

Checklist

microsoft-github-policy-service[bot] commented 4 months ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!NOTE] This label was added as per ITA06.

jchancellor-ms commented 4 months ago

@matt-FFFFFF - I discovered an issue where I couldn't use the key vault module for Disk Encryption Sets as they use the Key Vault Key ID instead of the full Azure Resource ID. I've made some quick changes to the outputs to include those two additional outputs for both keys and secrets. I didn't have time to run the E2E tests, but the PR should pick them up and run them.