search

Azure / terraform-azurerm-avm-res-keyvault-vault

Azure Verified Module for Key Vault
https://registry.terraform.io/modules/Azure/avm-res-keyvault-vault/azurerm/latest
MIT License
25 stars 29 forks source link

feat: Align to WAF - `public_network_access_enabled` set to `false` (breaking change) #69

Closed jtracey93 closed 8 months ago

jtracey93 commented 9 months ago

This pull request includes a change to the variables.tf file. The default value of the public_network_access_enabled variable has been switched from true to false, which means public access is not permitted by default now.

This is to align to WAF best practices

matt-FFFFFF commented 9 months ago

This is not needed as the network acls handle this

jtracey93 commented 9 months ago

These properties are slightly different. https://learn.microsoft.com/en-us/azure/key-vault/general/network-security#public-access-disabled-private-endpoint-only