Azure / terraform-azurerm-avm-res-keyvault-vault

Azure Verified Module for Key Vault

https://registry.terraform.io/modules/Azure/avm-res-keyvault-vault/azurerm/latest

MIT License

21 stars 24 forks source link

Secret object validation rules #92

Closed lestermarch closed 2 months ago

lestermarch commented 5 months ago

Description

This PR closes #71 by adding validation rules for secret names, not-before dates, and expiration dates.

Invalid name validation:

Invalid RFC 3339 date:

Type of Change

[ ] Non-module change (e.g. CI/CD, documentation, etc.)
[x] Azure Verified Module updates:
- [ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in locals.version.tf.json:
- [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an issue to report it yet.
- [x] Feature update backwards compatible feature updates, and I have bumped the MINOR version in locals.version.tf.json.
- [ ] Breaking changes and I have bumped the MAJOR version in locals.version.tf.json.
- [ ] Update to documentation

Checklist

[x] I'm sure there are no other open Pull Requests for the same update/change
[x] My corresponding pipelines / checks run clean and green without any errors or warnings
[x] I did run all pre-commit checks

lestermarch commented 5 months ago

@microsoft-github-policy-service agree

matt-FFFFFF commented 2 months ago

closing in favour of #113 - thanks for raising