search

Azure / terraform-azurerm-avm-res-keyvault-vault

Azure Verified Module for Key Vault
https://registry.terraform.io/modules/Azure/avm-res-keyvault-vault/azurerm/latest
MIT License
22 stars 25 forks source link

feat: Support lifecycle ignoreChanges with module #94

Open Hi-Fi opened 5 months ago

Hi-Fi commented 5 months ago

Check for previous/existing GitHub issues

Issue Type?

Feature Request

(Optional) Module Version

0.5.3

(Optional) Correlation Id

No response

Description

As Terraform doesn't support lifecycle meta-argument with modules (see hashicorp/terraform#27360) it would be nice that module would allow ignoring some things that are (at least in our environment) handled with policies. Of course the ignore can be more generic if possible, but at least for use tags and private_dns_zone_group.

matt-FFFFFF commented 3 months ago

Hi - we cannot support this due to limitations in Terraform - will keep open to track

rick-pb commented 3 months ago

are you able to provide an explanation of why this isn't supported? ignore changes should be able to be able to be added to the resource in the module.

matt-FFFFFF commented 3 months ago

Entries in ignore_changes must be static and cannot be passed in as variables.

Also they cannot be passed in through a call to a module.

Hence we are not able to provide a configurable list

matt-FFFFFF commented 3 months ago

However we have solved private dns zone group as we have a variable to control whether we manage this or not