Azure / terraform-azurerm-avm-res-machinelearningservices-workspace

AVM Module for Azure Machine learning workspaces.
MIT License
5 stars 7 forks source link

[AVM Module Issue]: Default example blocks compute from accessing public resources #27

Closed inchiosa closed 4 weeks ago

inchiosa commented 1 month ago

Check for previous/existing GitHub issues

Issue Type?

Bug

(Optional) Module Version

No response

(Optional) Correlation Id

No response

Description

To repro the bug, deploy the "default" example. Observe that "Workspace managed outbound access" is set to "Allow Internet Outbound" rather than "Disabled".

Default example:

image

AML Workspace created from the Portal using default settings:

image
microsoft-github-policy-service[bot] commented 1 month ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!TIP] For additional guidance on how to triage this issue/PR, see the TF Issue Triage documentation.

ritesh-modi commented 1 month ago

module "azureml" { source = "../../"

source = "Azure/avm-<res/ptn>-/azurerm"

...

location = var.location name = module.naming.machine_learning_workspace.name_unique resource_group = { name = azurerm_resource_group.this.name id = azurerm_resource_group.this.id } is_private = false enable_telemetry = var.enable_telemetry }

adding is_private = false should fix this

soallam commented 1 month ago

@oloomi please take a look at the comment above

cmaclaughlin commented 1 month ago

If "default" is intended to align with Azure Portal default, then shouldn't the "default" example have is_private variable to true?

Also, the description for the is_private variable is extremely ambiguous.

cmaclaughlin commented 4 weeks ago

Completed with PR #39