Azure / terraform-azurerm-avm-res-machinelearningservices-workspace

AVM Module for Azure Machine learning workspaces.
MIT License
9 stars 8 forks source link

Add compute instance creation for provisioning of managed vnet #34

Closed oloomi closed 2 months ago

oloomi commented 3 months ago

Description

This PR includes the following changes:

Type of Change

Checklist

vyta commented 3 months ago

Should this be required for managed vnet in order to enable container builds on the compute instance? Or should the container builds be a separate config option?

oloomi commented 2 months ago

Should this be required for managed vnet in order to enable container builds on the compute instance? Or should the container builds be a separate config option?

That's right, when the Azure Container Registry for our workspace is behind a virtual network, it can't be used to directly build Docker images. Instead, we need to configure our AML workspace to use a compute cluster or compute instance to build images.

Let's use this compute instance as the image builder and it serves both purposes: provisions the managed network, and it can be used for image building.

We need to use an Azure CLI command (or a Python code) after the workspace and compute instance are created to update the workspace and set the image-build-compute parameter to the created compute instance.

Setting the imageBuildComput property in the workspace at this stage creates a cycle and causes Terraform to fail.