Closed kewalaka closed 3 weeks ago
Converted to a draft, I will add some examples to cover new functionality.
@kewalaka let me know when you done, I will test and merge the PR. Thanks for your help and support.
added a test for re-write - I see azapi has bumped to v2.0.1 within the examples and this does have some breaking changes. I've just tested a terraform apply of the re-write example and that works fine - so the others will probably be ok.
i'll remove the WIP label - its a bit of a pain to test each one individually so be good to let the CI do a run and I'll follow up on any breakages, noting this is only going into a feature branch anyway!
@kewalaka, Thanks for your time, did quick review and avm test also pass merged with version-0.2.0 branch, I will test all examples once again and push to main branch.
Description
This is a merge into version 0.2.0
Breaking changes
Introduction of front end ip configuration & gateway configuration, to allow for these resources to be named by the customer and also support scenarios such as private link. I've re-adjusted the logic noting the decision around public IP address resource. Fixes #70
Gateway configuration now takes a subnet_id removing the data block and allowing for different resource group - fixes #54. I thought about having just a 'subnet_id' variable - but you need a gateway configuration block anyway to satisfy the above point (naming), so I think on balance it is better to make it more like the AzureRM interface.
Managed identities interface now aligns to spec fixes #68
Modified the simplified "enable_https" approach to use port & protocol instead - this fixes it to work with custom protocols such as tcp. Fixes #72 & #55
I believe the WAF configuration block should not be specified if you're using an external WAF policy (as all the examples that test WAF do already). Knowing this makes the
enable_classic_rule
flag redundant, if you do want to use classic WAF you just include awaf_configuration
block. We should (and currently do) promote the external WAF option, I would even argue for the classic WAF removal from the module interface, noting the flag to force an external WAF policy is already hard coded to true.Other changes
I have merged this with the output of newres, which should fix missing parameters.
Variables descriptions fixes #69
Add rewrite rule block fixes #66
Add match definition for probe configuration fixes #59
Fixes from grept-apply, included correct license copyright
Fixes from pre-commit/pr-check make targets
Example updates to align with the above. I've re-introduced a 'default' example, because grept expects it, moving the simplest of the existing ones into this folder.
I've checked these run to plan but need to complete E2E testing, sharing so that others can contribute.
-->
Type of Change
Checklist