search

Azure / terraform-azurerm-avm-res-network-expressroutecircuit

AVM Terraform module for ExpressRoute Circuits.
MIT License
1 stars 1 forks source link

[AVM Module Issue]: Set nullable false on collection variables #34

Closed adammontlake closed 3 weeks ago

adammontlake commented 1 month ago

Check for previous/existing GitHub issues

Issue Type?

Bug

(Optional) Module Version

0.1.0

(Optional) Correlation Id

No response

Description

Per TFNFR20 - validate that all collection variables nullable = false. The following vars should be included: express_route_circuit_authorizations peerings vnet_gw_connections

adammontlake commented 1 month ago

@jchancellor-ms As per the TFNFR20 we need to set nullable = false, but in our case, all the above mentioned variables can be empty. They all have a default = {} for a purpose - if a circuit is just being created, before provision is complete, a user cannot set peerings or connections. Regarding the authorizations, they might not be required if the connection is in the same tenant.

What are the AVM guidelines in this case?

microsoft-github-policy-service[bot] commented 1 month ago

[!WARNING] Tagging the AVM Core Team (@Azure/avm-core-team-technical-terraform) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

[!TIP]

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage :mag:" label must be removed as part of the triage process (when the issue is first responded to)!
matt-FFFFFF commented 1 month ago

@adammontlake can you give an example?

A default of empty map {} is fine and perfectly compatible with nullable = false

adammontlake commented 1 month ago

Thanks @matt-FFFFFF This will be solved as part of pr #29