Azure / terraform-azurerm-avm-res-resources-resourcegroup

To gain access, please finish setting up this repository now at:

https://repos.opensource.microsoft.com/Azure/wizard?existingreponame=terraform-azurerm-avm-res-resources-resourcegroup&existingrepoid=764113620

MIT License

7 stars 9 forks source link

Fixing Idempotent tests #32

Closed kevball2 closed 3 months ago

kevball2 commented 4 months ago

Description

Type of Change

[ ] Non-module change (e.g. CI/CD, documentation, etc.)
[x] Azure Verified Module updates:
- [x] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in locals.version.tf.json:
- [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
- [x] The bug was found by the module author, and no one has opened an issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in locals.version.tf.json.
- [ ] Breaking changes and I have bumped the MAJOR version in locals.version.tf.json.
- [ ] Update to documentation

Checklist

[x] I'm sure there are no other open Pull Requests for the same update/change
[x] My corresponding pipelines / checks run clean and green without any errors or warnings
[x] I did run all pre-commit checks

kevball2 commented 4 months ago

@JFolberth @matebarabas could you please start the workflows at your convenience!

JFolberth commented 4 months ago

@kevball2 looks like the latest linting checks failed on the ReadMe update.

kevball2 commented 4 months ago

@JFolberth, I re-ran the pre-commit step and the readme files have been updated.

kevball2 commented 4 months ago

@JFolberth would you be able to re-start the e2e tests? I don't think they are actually ran or maybe I don't have rights to view the run log