Azure / terraform-azurerm-avm-res-servicebus-namespace

https://registry.terraform.io/modules/Azure/avm-res-servicebus-namespace/azurerm

MIT License

3 stars 5 forks source link

Update terraform.tf #47

Closed davenicoll closed 3 months ago

davenicoll commented 4 months ago

Description

Fixes #44

Type of Change

[ ] Non-module change (e.g. CI/CD, documentation, etc.)
[x] Azure Verified Module updates:
- [x] Bugfix containing backwards compatible bug fixes
- [x] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an issue to report it yet.
- [ ] Feature update backwards compatible feature updates.
- [ ] Breaking changes.
- [ ] Update to documentation

Checklist

[x] I'm sure there are no other open Pull Requests for the same update/change
[x] My corresponding pipelines / checks run clean and green without any errors or warnings
[x] I did run all pre-commit checks

Girish-Maddineni commented 4 months ago

@lonegunmanb @jaredfholgate @matt-FFFFFF @AlexanderSehr can anyone of you please review and approve the workflows to keep it moving and get it to merge :)

davenicoll commented 4 months ago

@microsoft-github-policy-service agree

Girish-Maddineni commented 4 months ago

@lonegunmanb @jaredfholgate @matt-FFFFFF @AlexanderSehr Fixed the workflow failure caused by documentation linter and can anyone of you please review and approve workflows again to keep it moving and get it to merge :)

Girish-Maddineni commented 4 months ago

@matt-FFFFFF can I have one last set of approval/review on E2E Test workflows please..:)

davenicoll commented 3 months ago

@lonegunmanb @jaredfholgate @matt-FFFFFF @AlexanderSehr help please! The E2E tests for examples seem to be failing. Apologies for the ping - the bug this PR fixes has been blocking our dependent pipelines for a over a week.

AlexanderSehr commented 3 months ago

@lonegunmanb @jaredfholgate @matt-FFFFFF @AlexanderSehr help please! The E2E tests for examples seem to be failing. Apologies for the ping - the bug this PR fixes has been blocking our dependent pipelines for a over a week.

Hey @davenicoll, I can't say that I know the CI for TF very well. @matt-FFFFFF / @segraef / @mbilalamjad could you support? As per @davenicoll's statement, this is not going well for some time.

matt-FFFFFF commented 3 months ago

I think this is an impotency issue:

                  ~ key_vault_key_id                  = "https://kv-lodhcmk-auto.vault.azure.net/keys/customermanagedkey" -> "https://kv-lodhcmk-auto.vault.azure.net/keys/customermanagedkey/"

matt-FFFFFF commented 3 months ago

Seems like an annoying formatting problem with an unnecessary trailing slash

bryansan-msft commented 3 months ago

E2E tests are just unreliable for some reason. I'm still fighting on that. I will merge this PR since it is just a silly change

davenicoll commented 3 months ago

Thanks for the help @matt-FFFFFF @bryansan-msft, appreciate it.