search

Azure / terraform-azurerm-avm-res-sql-managedinstance

MIT License
0 stars 4 forks source link

[AVM Module Issue]: Transparent Data Encryption for SQL MI AVM module #17

Open chianw opened 1 month ago

chianw commented 1 month ago

Check for previous/existing GitHub issues

Issue Type?

Feature Request

(Optional) Module Version

No response

(Optional) Correlation Id

No response

Description

Customer is requesting for transparent data encryption on SQL MI. This is available via azurerm resource "azurerm_mssql_managed_instance_transparent_data_encryption" supporting both service-managed and customer-managed keys - https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/mssql_managed_instance_transparent_data_encryption

Does it make sense to include this feature as part of the SQL MI AVM module or it should be handled outside of the module?

mbilalamjad commented 1 month ago

Hey @chianw please see below, you should be able to enable TDE with service and customer managed keys, let me know if this helps

https://github.com/Azure/terraform-azurerm-avm-res-sql-managedinstance/blob/071b33822b07061b322c4bb701848278b26146b8/main.tf#L85-L102

chianw commented 1 month ago

Hi @mbilalamjad yes this looks like what the customer needs. Will you be creating a new release for this feature?