Azure / terraform-azurerm-avm-res-storage-storageaccount

This Terraform module is designed to create Azure Storage Accounts and its related resources, including blob containers, queues, tables, and file shares. It also supports the creation of a storage account private endpoint which provides secure and direct connectivity to Azure Storage over a private network.
https://registry.terraform.io/modules/Azure/avm-res-storage-storageaccount
MIT License
22 stars 36 forks source link

Add support for mandatory private endpoints #133

Closed on4tux closed 2 months ago

on4tux commented 4 months ago

Is there an existing issue for this?

Description

In our company, users need to create private endpoint on Storage Account to be able to access it. This PE needs to exist and have its dns zone propagated before you can create subresources like a container. A workaround is to wait 5 mins after PE creation but other solutions might be possible as well.

New or Affected Resource(s)/Data Source(s)

time_sleep

Potential Terraform Configuration

resource "time_sleep" "wait_5_min_containers" {
  create_duration = "5m"

  depends_on = [azurerm_private_endpoint.this]
}

References

No response

lonegunmanb commented 3 months ago

@on4tux Thanks for opening this issue, would we declare this time_sleep resource outside this module, and list the module instance in it's depends_on list? For this example, we can add such a time_sleep in it's main.tf file:

resource "time_sleep" "wait_5_min_containers" {
  create_duration = "5m"

  depends_on = [module.this]
}
chinthakaru commented 3 months ago

@on4tux As suggested by @lonegunmanb, you could incorporate time_sleep into main.tf within the examples. At present, there are no plans to integrate a timer into the module.

microsoft-github-policy-service[bot] commented 3 months ago
microsoft-github-policy-service[bot] commented 3 months ago

[!IMPORTANT] @on4tux, this issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

microsoft-github-policy-service[bot] commented 2 months ago

[!WARNING] @on4tux, this issue will now be closed, as it has been marked as requiring author feedback but has not had any activity for 7 days.