Azure / terraform-azurerm-avm-res-storage-storageaccount

This Terraform module is designed to create Azure Storage Accounts and its related resources, including blob containers, queues, tables, and file shares. It also supports the creation of a storage account private endpoint which provides secure and direct connectivity to Azure Storage over a private network.
https://registry.terraform.io/modules/Azure/avm-res-storage-storageaccount
MIT License
19 stars 27 forks source link

[AVM Module Issue]: property `enable_https_traffic_only` has been superseded by `https_traffic_only_enabled` for the resource azurerm_storage_account #139

Closed Sakthidasakalathi closed 1 month ago

Sakthidasakalathi commented 1 month ago

Check for previous/existing GitHub issues

Issue Type?

I'm not sure

(Optional) Module Version

0.2.1

(Optional) Correlation Id

No response

Description

Warning: Argument is deprecated │ │ with module.webapp_storage_account.azurerm_storage_account.this, │ on .terraform\modules\webapp_storage_account\main.tf line 17, in resource "azurerm_storage_account" "this": │ 17: enable_https_traffic_only = var.enable_https_traffic_only │ │ The property enable_https_traffic_only has been superseded by https_traffic_only_enabled and will be removed in v4.0 of the AzureRM Provider.

chinthakaru commented 1 month ago

@Sakthidasakalathi Thank you for reaching out. The issue was resolved last week and has been merged with the main branch.

Sakthidasakalathi commented 1 month ago

@chinthakaru I see the updates on the main branch, but still terraform init pulls the older bugged configuration files with the tag v0.2.1. I'm calling this module from terraform public registry, shouldn't this module be published with the new version tagging into terraform registry? I still see the old version in terraform registry, I'm not sure if I'm missing anything on my end.

Tried below configuration to call the module, with and without version, but the init pulls only the older files.

module "module_name" { source = "Azure/avm-res-storage-storageaccount/azurerm"

module "module_name" { source = "Azure/avm-res-storage-storageaccount/azurerm" version = "0.2.1"

chinthakaru commented 1 month ago

@Sakthidasakalathi All the changes have been synced and made a new release. Please can you test this again ?

Sakthidasakalathi commented 1 month ago

@chinthakaru, Thank you.! All looks good.

chinthakaru commented 1 month ago

@Sakthidasakalathi thanks for the update. let me close the issue.