Azure / terraform-azurerm-avm-res-storage-storageaccount

This Terraform module is designed to create Azure Storage Accounts and its related resources, including blob containers, queues, tables, and file shares. It also supports the creation of a storage account private endpoint which provides secure and direct connectivity to Azure Storage over a private network.
https://registry.terraform.io/modules/Azure/avm-res-storage-storageaccount
MIT License
22 stars 37 forks source link

Fix `subresource_name` Property #89

Closed ASHR4 closed 5 months ago

ASHR4 commented 6 months ago

Description

84 reported - `Inappropriate value for attribute "subresource_name": string required.

Reviewing the azurerm provider, the subresource_name property within the ip_configuration block is a string. The subresource_names property within the private_service_connection is a list(string).

This module reuses the list(string) variable causing issues when trying to configure the ip_configuration block.

This PR updates the ip_configuration variable to have its own string subresource_name property and the subresource_name variable used within private_service_connection has been renamed to subresource_names.

This will cause a breaking change for people; required to make subresource_name plural.

Upon having issues with the az_api and seeing the provider does not support the update timeout, I removed the update operation, closing #85 and #78 :)

Closes #78 Closes #84 Closes #85

Type of Change

Checklist

I did receive errors from the linter in the pr-checks but it seems to be regarding old interfaces and I felt a seperate PR would be more appropriate.