Azure / terraform-azurerm-avm-template

Template repo for Azure Verified Modules using Terraform
MIT License
40 stars 27 forks source link

alignment with AVM specification & grept-apply requirements #106

Closed kewalaka closed 5 months ago

kewalaka commented 5 months ago

Description

This re-aligns the template with changes to the docs / AVM specification & fixes reported by grept-apply.

There are some existing PRs which repeat the same functionality, adding tags & new files to .gitignore based on grept-apply outputs, I believe this is more comprehensive (cc @jaredfholgate for a check)

It introduces the fix for private endpoints conflicting with Azure Policy based on the spec, with some corrections raised with @matt-FFFFFF here; https://github.com/Azure/terraform-azurerm-avm-res-keyvault-vault/issues/32#issuecomment-2050367744

I've used this as the starting point for the SQL Module that I'm preparing to post, as you can't properly lint this code due to things like TODOs.

-->

Type of Change

Checklist

microsoft-github-policy-service[bot] commented 5 months ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!NOTE] This label was added as per ITA06.

kewalaka commented 5 months ago

this also includes the fix for the location / "evil data source" 😅