search

Azure / terraform-azurerm-avm-template

Template repo for Azure Verified Modules using Terraform
MIT License
40 stars 27 forks source link

[AVM Question/Feedback]: Resource Naming in terraform-azurerm-avm-template #113

Open JFolberth opened 3 months ago

JFolberth commented 3 months ago

Check for previous/existing GitHub issues

Description

Not sure best way to accommodate but AVM checklist calls out the need to add "resourceType-" as a variable/local for Terraform. The example today validates the name being passed into the module to ensure all lower case and numbers...the "-" will break this. https://azure.github.io/Azure-Verified-Modules/specs/shared/#id-snfr25---category-composition---resource-naming

The easy fix is to add the "-" into the validation rule. However looking to see if we should also add a TODO in variables w/ the default value corresponding to the resource name and curious if this should be accommodated for in the default testing process.

microsoft-github-policy-service[bot] commented 3 months ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!NOTE] This label was added as per ITA06.

matt-FFFFFF commented 3 months ago

Hi @JFolberth can you point me to the code in the repo that needs to change?

Thanks