search

Azure / terraform-azurerm-avm-template

Template repo for Azure Verified Modules using Terraform
MIT License
41 stars 27 forks source link

Update terraform.tf #90

Closed JFolberth closed 6 months ago

JFolberth commented 6 months ago

Update min versions as called out https://github.com/Azure/terraform-azurerm-avm-res-managedidentity-userassignedidentity/pull/1#pullrequestreview-1916775159

segraef commented 6 months ago

Was this agreed with @matt-FFFFFF since your change removes the major version constraint?

matt-FFFFFF commented 6 months ago

This is fine, it's just another way of writing the same thing.

lonegunmanb commented 6 months ago

I don't think we need this pr for this template. I understand that @JFolberth want this change because the change he'd like to introduce in https://github.com/Azure/terraform-azurerm-avm-res-managedidentity-userassignedidentity/pull/1#pullrequestreview-1916775159 require this min versions restriction, but they're not required by all AVM repos. Each AVM repo could keep it's own provider versions restriction, but I think it's better to keep a loose restriction here in the template repo, otherwise enforcing a high version requirement could block our users from using some AVM modules. WDYT @JFolberth @matt-FFFFFF ?

JFolberth commented 6 months ago

I have no preference either way. Was just closing the loop on feedback from the module I was working on if it was something that should be addressed back to the template level.