Azure / terraform-azurerm-caf-enterprise-scale

Azure landing zones Terraform module
https://aka.ms/alz/tf
MIT License
815 stars 528 forks source link

Bug Report: Customization of new management resources not working as expected #1028

Open steph409 opened 1 month ago

steph409 commented 1 month ago

Community Note

Versions

terraform:

azure provider:

module: 6.0.0

Description

I want to customize the new management resources. This works fine for some parts, and not for others. I saw the following:

In the submodule "management", there are ultimately three data collection rules which are defined:

The way the custom parameter work in this case is not straight forward. It might just be a simple copy-paste error: In the custom settings, there are only two local variables defined for the overrides:

So from my understanding, there is already one missing, the one for sql.

Then, when used, in the same file, things get mixed up. For example, it seems not possible to explicitly specify the three data collection rule names.

image

Also from what I can see, the way to set tags for all management resources using configure_management_resources.tags does not work for the new resources.

Describe the bug

Steps to Reproduce

  1. step 1
  2. step 2
  3. you get it...

Screenshots

Additional context

matt-FFFFFF commented 1 month ago

Thank you for identifying these issues @steph409 - Your diligence is most helpful 😊

We will put on our backlog to fix or would be welcoming of a PR to do the same

MoussaBangre commented 14 hours ago

Also facing the same issue. Any progress on that ?