Add support for azurerm provider v4

[stawik-mesa]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Is your feature request related to a problem?

Unable to upgrade my code and use azurerm v4.0.1.

Describe the solution you'd like

Currently the version is pinned to ~> 3.107. Therefore I am unable to upgrade to v4.

│ Error: Failed to query available provider packages
│ 
│ Could not retrieve the list of available versions for provider hashicorp/azurerm: no available releases match the given constraints ~> 3.107, ~> 4.0, ~> 4.0.1
╵

Additional context

https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/guides/4.0-upgrade-guide

[matt-FFFFFF]

Hi @stawik-mesa

We haven't yet tested this module with AzureRM 4.0.

If there are no breaking changes then we will update the provider version constraint. If there are we will await v7.0 of this module.

[stawik-mesa]

Hi @stawik-mesa

We haven't yet tested this module with AzureRM 4.0.

If there are no breaking changes then we will update the provider version constraint. If there are we will await v7.0 of this module.

Hi @matt-FFFFFF Thank you for the update. I just checked on the removed resources, none of them are used within this module. The only changes are on the following resources:

• [x] azurerm_automation_account.management - The deprecated encryption.key_source property has been removed. - This field is not used within the module.
• [ ] azurerm_firewall_policy.connectivity, azurerm_firewall_policy.virtual_wan - The sku property now defaults to Standard.
• [ ] azurerm_log_analytics_workspace.management - The sku property no longer supports the value Free.
• [ ] azurerm_public_ip.connectivity - The sku property now defaults to Standard.
• [ ] azurerm_subnet.connectivity
  • [ ] The actions block has become a Set instead of a List, meaning that the order of these items no longer matters. If you're referencing these items within your Terraform Configuration, then this may require some code changes.
  • [x] The deprecated private_endpoint_network_policies_enabled property has been removed in favour of the private_endpoint_network_policies property. - Not used
  • [x] The deprecated enforce_private_link_endpoint_network_policies property has been removed in favour of the private_endpoint_network_policies property. - Not used
  • [x] The deprecated enforce_private_link_service_network_policies property has been removed in favour of the private_link_service_network_policies_enabled property. - Not used
  • [ ] The private_endpoint_network_policies property now defaults to Disabled. - Not configurable, default value will change.
  • [ ] The private_link_service_network_policies_enabled property now defaults to true. - Configurable defaults to null, so default behaviour will change.
• [ ] azurerm_virtual_network.connectivity - The address_space property has been changed from a list to a set. If you're referencing an element in this property then this will require code changes.
• [ ] azurerm_vpn_gateway.virtual_wan - The routing_preference property now defaults to Microsoft Network.

Not sure how this should be treated. For the changed default values from the provider, the "old" defaults could be set as default from the module instead of passing "null". And remove this with the next major release. What do you think?

[matt-FFFFFF]

Thank you for this detailed analysis. It looks like breaking changes are likely, meaning we will have to target v7

[matt-FFFFFF]

We will test to confirm