search

Azure / terraform-azurerm-caf-enterprise-scale

Azure landing zones Terraform module
https://aka.ms/alz/tf
MIT License
855 stars 562 forks source link

management/log-analytics: Allow users to set a daily GB cap #1143

Open c4milo opened 3 weeks ago

c4milo commented 3 weeks ago

setting retention_in_days worked OK, but setting daily_quota_gb did not. We configured the daily cap from the Azure Portal but this automation rolls it back to be disabled. This PR makes it so we can set a value for our environment, and it is not rolled back. 

  # module.alz.azurerm_log_analytics_workspace.management["/subscriptions/96f9ca86-6842-4c2f-aada-2daafa1b0b9c/resourceGroups/redpanda-mgmt/providers/Microsoft.OperationalInsights/workspaces/redpanda-la"] will be updated in-place
  ~ resource "azurerm_log_analytics_workspace" "management" {
      ~ daily_quota_gb                          = 64 -> -1
        id                                      = "/subscriptions/96f9ca86-6842-4c2f-aada-2daafa1b0b9c/resourceGroups/redpanda-mgmt/providers/Microsoft.OperationalInsights/workspaces/redpanda-la"
        name                                    = "redpanda-la"
        tags                                    = {
            "deployedBy"   = "terraform/azure/caf-enterprise-scale"
            "redpanda-org" = "azure-governance"
        }
        # (14 unchanged attributes hidden)
    }
c4milo commented 3 weeks ago

@matt-FFFFFF, we also bumped into this small but important detail.