search

Azure / terraform-azurerm-caf-enterprise-scale

Azure landing zones Terraform module
https://aka.ms/alz/tf
MIT License
869 stars 574 forks source link

feature: support for jsonc in library folder #1165

Open kewalaka opened 1 month ago

kewalaka commented 1 month ago

Policy gets confusing quickly, and its not easy to keep track of the reason for why things have been done a specific way in the lib folder.

Is there any technical reason why .jsonc could not be added to the list - from a cursory glance it looks like it is just finding lines such as the following:

https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/blob/0ae041755b3e1fc41b75d57eb47e22061151d5b1/modules/archetypes/locals.policy_set_definitions.tf#L12

& adding the extra extensions (.jsonc & potentially .jsonc.tmpl) ?

matt-FFFFFF commented 2 weeks ago

I haven't experimented with this but if you want to do so and submit a PR I will be happy to merge it

microsoft-github-policy-service[bot] commented 2 days ago

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.