Azure / terraform-azurerm-caf-enterprise-scale

Azure landing zones Terraform module
https://aka.ms/alz/tf
MIT License
857 stars 569 forks source link

Renaiming again (Virtual Network Links) #755

Open infazops opened 1 year ago

infazops commented 1 year ago

Community Note

Description

Is your feature request related to a problem? No

Describe the solution you'd like

When linking the record to a vnet using caf-enterprise-scale we end up with the first entry in this screen shot image We would like it to be just "vnl-hub-vnet", so it can match the spoke links below, that were done manually from the gui portal

What we have tried. In settings.connectivity.tf

advanced = {
      custom_settings_by_resource_type = {
        azurerm_private_dns_zone_virtual_network_link = {
          connectivity = {
            name = "vnl-hub-vnet"
          }
        }
      }
    }

Since this is a hub network related setting, we have also tried

advanced = {
      custom_settings_by_resource_type = {
        hub_virtual_networks_for_dns = {
            name = "vnl-hub-vnet"
          }
        }
}

... and some other combinations of the above, which we don't want to bore you with.

We expect terraform plan to show that it will destroy the existing links and setup new links with the new link name. We get nothing. Any help much appreciated

birdnathan commented 1 year ago

There is no advanced setting capability in the code for private dns zone link names. See modules/connectivity/locals.tf

Logic needs added to the name fields in the resource block starting at line 1583.

matt-FFFFFF commented 1 year ago

Thanks @infazops

We will put this on our backlog for prioritization