search

Azure / terraform-azurerm-computegroup

Terraform Azure RM Compute Group Module
MIT License
10 stars 37 forks source link

Rake e2e tests fail #15

Open dtzar opened 6 years ago

dtzar commented 6 years ago

When you run rake e2e the tests fail with:

$$$$$$ Running command `terraform destroy -force -lock=true -lock-timeout=0s -input=false -no-color -parallelism=1 -refresh=true  -var-file=/tf-test/module/test/integration/fixtures/testing.tfvars /tf-test/module`    
       Error: Required variable not set: load_balancer_backend_address_pool_ids    
       Error: Required variable not set: vnet_subnet_id

These are not able to be specified since they are an output from a different module. The module code works flawlessly. Therefore, the test framework / code needs to be updated to accomodate this scenario.

dcaro commented 6 years ago

@metacpp can you have a look at this?

metacpp commented 6 years ago

Why the test case is broken here? Regression ? @VaijanathB can you take a look at the test case you added here ?

metacpp commented 6 years ago

@dtzar I have enabled the branch protection here, if the travis fails, it will block the merge.

metacpp commented 6 years ago

We've migrated the test framework to Terratest in #18. There's still failure after merge: https://travis-ci.org/Azure/terraform-azurerm-computegroup/builds/420907668

@JunyiYi please take a look at this issue.

foreverXZC commented 6 years ago

@metacpp When I was trying e2e test locally using docker, sometimes I also met this problem. However, if I restart the test, it may pass the build. I wonder why the tests are not consistent.