Azure / terraform-azurerm-lz-vending

Terraform module to deploy landing zone subscriptions (and much more) in Azure
https://registry.terraform.io/modules/Azure/lz-vending/azurerm
MIT License
169 stars 78 forks source link

feat: add an email recipient for the email notification of Defender for Cloud #277

Open Christian12cc opened 1 year ago

Christian12cc commented 1 year ago

Description

To receive security alert, add an email recipient for the email notification of Defender for Cloud

Describe the solution you'd like

The defender for cloud settings "email notification" of the subscription is set with an email (for example security team email).

Additional context

felipebbc commented 8 months ago

Working on this feature request. Currently creating a new submode for Defender for Cloud to allow setting the security contact, including email, phone, alertNotifications, notificationsByRole. Goal is for the new submodule to later also allow enabling Defender for Cloud plans (issue #136).

matt-FFFFFF commented 8 months ago

Hey! Thanks so much for your efforts.

As these resources are part of the subscription, please can you add it to that submodule?

felipebbc commented 8 months ago

Hey! Thanks so much for your efforts.

As these resources are part of the subscription, please can you add it to that submodule?

Hey Matt. I added the code to the existing subscription submodule and submitted the PR. Let me know if this works or if there is a better way to do this. Like I mentioned, adding support to enable the Defender for Cloud plans would be next so when the subscription is vended it has the right security guardrails ready and not entirely relying on Azure Policy DINE to enable it. Thanks