Azure / terraform-azurerm-openai

Terraform module for deploying Azure OpenAI Service.

MIT License

44 stars 33 forks source link

When user provides a private DNS zone we assume it is already linked to the vnet #93

Closed zioproto closed 2 months ago

zioproto commented 3 months ago

Describe your changes

When the user provides var.private_dns_zone the DNS zone is already shared with other services and then we should expect it is already linked to the Vnet.

Issue number

92

Checklist before requesting a review

[X] The pr title can be used to describe what this pr did in CHANGELOG.md file
[X] I have executed pre-commit on my machine
[X] I have passed pr-check on my machine

zioproto commented 3 months ago

@jmturwy could you please confirm if this change would solve your issue ? Would you be able to test this ? thanks

jmturwy commented 3 months ago

@jmturwy could you please confirm if this change would solve your issue ? Would you be able to test this ? thanks

yes i should be able to test today or tomorrow, standby

zioproto commented 2 months ago

@jmturwy any update on this ?