Azure / terraform-azurerm-virtual-machine

Terraform Azure RM Virtual Machine Module
MIT License
36 stars 36 forks source link

Support `bypass_platform_safety_checks_on_user_schedule_enabled` and `reboot_setting` #66

Closed davidkarlsen closed 9 months ago

davidkarlsen commented 9 months ago

Describe your changes

Adds support for bypass_platform_safety_checks_on_user_schedule_enabled as well as reboot_setting

Issue number

65

Checklist before requesting a review

Thanks for your cooperation!

davidkarlsen commented 9 months ago

thanks @lonegunmanb - I think I got all fixed now.

davidkarlsen commented 9 months ago

@lonegunmanb if it passes and you like it - can you push a new tag? TIA

davidkarlsen commented 9 months ago

@lonegunmanb wdyt?

lonegunmanb commented 9 months ago

@lonegunmanb if it passes and you like it - can you push a new tag? TIA

Sure thing, I can publish a new version for this pr. @davidkarlsen

davidkarlsen commented 9 months ago

Hi @davidkarlsen we have another syntax error needs to be fixed. Would you please check pre-comment document and run the check before you commit? Thanks!

done

davidkarlsen commented 9 months ago

@lonegunmanb

docker run --rm -v $(pwd):/src -w /src mcr.microsoft.com/azterraform:latest make pre-commit &> log
cat log|grep -v "downloading "
 terraform-azurerm-virtual-machine  cat log|grep -v "downloading "
==> Formatting terraform code...
terraform fmt -recursive
==> Fixing test and document terraform blocks code with terrafmt...
time="2023-11-22 10:26:58" level=error msg="block 3 @ ./README.md:93 failed to process with: failed to parse hcl: ./README.md:2,26-27: Invalid expression; Expected the start of an expression, but found an invalid expression token.\nmodule \"example\" {\n  source               = <module_source>\n  ...\n  tracing_tags_enabled = true\n}\n"
time="2023-11-22 10:26:58" level=error msg="block 4 @ ./README.md:105 failed to process with: failed to parse hcl: ./README.md:2,25-26: Invalid expression; Expected the start of an expression, but found an invalid expression token.\nmodule \"example\" {\n  source              = <module_source>\n  ...\n  tracing_tags_prefix = \"custom_prefix_\"\n}\n"
==> Fixing source code with gofmt...
# This logic should match the search logic in scripts/gofmtcheck.sh
find . -name '*.go' | grep -v vendor | xargs gofmt -s -w
==> Fixing source code with Gofumpt...
# This logic should match the search logic in scripts/gofmtcheck.sh
find . -name '*.go' | grep -v vendor | xargs gofumpt -w
--> Generating doc
README.md updated successfully
davidkarlsen commented 9 months ago

This seems to fail due to infra:

performing CreateOrUpdate: unexpected status 409 with error: OperationNotAllowed: Operation could not be completed as it results in exceeding approved standardFSv2Family Cores quota.