search

Azure / terraform-azurerm-vnetpeering

Module to create and manage virtual network peering which allows resources to access other resources in the linked virtual network.
MIT License
9 stars 33 forks source link

Updated to current Terrafom HCL Syntax #11

Open diogomaul opened 2 years ago

diogomaul commented 2 years ago

Hello, here are the proposed changes:

  1. Removed quotes from variables types.
  2. Removed quotes from providers declaration.
  3. Removed "${}" everywhere in the code as it's no longer required for variables.

This new version was tested locally and runs perfectly on TF version 1.1.8.

ghost commented 2 years ago

CLA assistant check
All CLA requirements met.

lonegunmanb commented 2 years ago

Hello @diogomaul , thanks for opening this pr! LGTM except for two lines. Would you please consider deleting these two lines instead of commenting them off? Thanks!

diogomaul commented 2 years ago

Hi @lonegunmanb, which two lines are you referring to? I kind of new to GitHub, so maybe I'm missing something, please let me know.

lonegunmanb commented 2 years ago

Hi @diogomaul , would you please delete this line and this line ? Thanks!

glanchow commented 2 months ago

can you merge please ?

chopeen commented 1 week ago

@lonegunmanb I am looking into adding vnet peering in my project. Should I consider using this module? Is it still supported?