search

Azure / terraform

Source code for the Azure Marketplace Terraform development VM package.
MIT License
698 stars 794 forks source link

Module for Azure Event Hub #21

Open jcorioland opened 5 years ago

jcorioland commented 5 years ago

Publish a module to Terraform Registry that helps to deploy Azure Event Hub.

Related Terraform resources:

abymsft commented 5 years ago

@jcorioland I would like to work on this module. Will start by going through the shared resources.

jcorioland commented 5 years ago

Awesome! Let me know if you need any help!

abymsft commented 5 years ago

@jcorioland who should I add as a reviewer ? I was thinking of getting the chunks reviewed instead of an entire repo. If any suggestions ? please share the GitHub username and I'll add as a reviewer

jcorioland commented 5 years ago

Maybe @grayzu or @echuvyrov can help for the review? @abymsft can you share your repo please?

grayzu commented 5 years ago

@abymsft Yes, I would be happy to review your progress.

abymsft commented 5 years ago

Repo @grayzu Sent you the invite. as soon as you accept I'll add you as the reviewer to the PR raised.

P.S. I dont know how to write the test cases. this PR doesn't have the test cases. I do plan to add them at a later stage.

jcorioland commented 5 years ago

Hey @abymsft, any update on this one? Were you able to finish your module? Thanks!

abymsft commented 5 years ago

@jcorioland still struggling with writing a meaningful go test.