Closed abeebu closed 3 months ago
@lonegunmanb Would you be able to review this PR please?
@lonegunmanb Would you be able to review this PR please?
Hi @abeebu thanks for opening this pr! Overall it LGTM but I found that you've created a private dns zone for event hub, but no resource for event hub, no azurerm_eventhub
, no private endpoint or private link for eventhub. Is that correct?
@lonegunmanb Would you be able to review this PR please?
Hi @abeebu thanks for opening this pr! Overall it LGTM but I found that you've created a private dns zone for event hub, but no resource for event hub, no
azurerm_eventhub
, no private endpoint or private link for eventhub. Is that correct?
@lonegunmanb yes, this configuration utilizes the built-in eventhub endpoint for iothub. So we(the customer) does not need to deploy a separate eventhub resource. However to ensure private connectivity between the iothub and its builtin endpoint, we need to add the private dns zone and create a dns record for its IP.
See here for more details on the builtin endpoint.
In a follow up PR later this month, I will also show the configuration for deploying the iothub together with a separate storage resource and eventhub resource for message routing all behind a VNET.
Just a nudge that this PR is awaiting your action @lonegunmanb 😁
Tagging you @stemaMSFT and @TomArcherMsft 🙂
@abeebu Thanks much for the contribution.
If you haven't done so already, please read the Contributor Guide article, "Publish a Terraform Quickstart".
>= 3.35.0, < 4.0.0
. I'm assuming you're specifying 3.35 and above but less than 4.0. Is that correct? If so, the canonical way to write that is ~> 3.351
. The pessimistic constraint operator (the tilde) basically tells Terraform that you want the latest version but only incrementing the right-most version component.Apology for the late reply @abeebu & @TomArcherMsft , LGTM!
This PR adds a new quickstart sample for deploying iothub with device provisioning service behind a virtual network