search

Azure / terraform

Source code for the Azure Marketplace Terraform development VM package.
MIT License
693 stars 784 forks source link

AI Studio terraform templates #322

Closed andyaviles121 closed 2 months ago

andyaviles121 commented 3 months ago

@grayzu @stemaMSFT @lonegunmanb can someone take a look at this pr? cc: @deeikele

andyaviles121 commented 3 months ago

@grayzu changes have been made.

grayzu commented 3 months ago

Looks good to me.

andyaviles121 commented 3 months ago

@grayzu when can this be merged?

stemaMSFT commented 3 months ago

@andyaviles121 please fix the issues with the PR. When it passes e2e tests we can merge.

stemaMSFT commented 3 months ago

@lonegunmanb looks like this e2e is failing because of some sort of race condition or deadlock based on the logs. Can you take a look?

andyaviles121 commented 3 months ago

@lonegunmanb have you had a chance to look over this pr? I'm not sure how to fix issues with the e2e check failure

andyaviles121 commented 3 months ago

@lonegunmanb is the issue due to the reused resource names? Seems like the key vault is having issues being created. cc: @deeikele

andyaviles121 commented 3 months ago

@stemaMSFT can you try to run the e2e test again? I added in a section to the azurerm provider to hopefully help with the key vault issues.

deeikele commented 2 months ago

@stemaMSFT Can you please help unblock this E2E build? This seems not triggerable on our side. We have several customers looking for these templates to be merged? Thanks!

stemaMSFT commented 2 months ago

Sorry for letting this slip for a few weeks. Just kicked off those E2E tests.

stemaMSFT commented 2 months ago

@andyaviles121 @deeikele @lonegunmanb we're still running into E2E test issues.

stemaMSFT commented 2 months ago

@andyaviles121 @lonegunmanb the e2e tests have failed again, could you take a look?

andyaviles121 commented 2 months ago

@stemaMSFT seemed like the connection had an incorrect field. I removed it. Can you try the e2e test again?

TomArcherMsft commented 2 months ago

cc: @stemaMSFT

@andyaviles121 I'm running the e2e tests now.

TomArcherMsft commented 2 months ago

cc: @grayzu, @stemaMSFT. @lonegunmanb

@andyaviles121 This sample is failing in part because it doesn't adhere to the Contributor Guide requirements for Terraform samples. https://review.docs.microsoft.com/en-us/help/contribute/global-terraform-template?branch=main

andyaviles121 commented 2 months ago

@TomArcherMsft I rewrote the files to match the contributor guide. Can you review and run the e2e tests?

TomArcherMsft commented 2 months ago

@andyaviles121 This looks good. Please change "output.tf" to "outputs.tf" and I'll run the e2e tests. Thanks.

andyaviles121 commented 2 months ago

@TomArcherMsft done :)

TomArcherMsft commented 2 months ago

CC: @andyaviles121

@stemaMSFT @lonegunmanb I ran the e2e tests and it looks as though everything passes now: https://github.com/Azure/terraform/actions/runs/9616809065/job/26527170852?pr=322

Can this PR be merged now?